Skip to content

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Nov 6, 2025

Fixes: #35913
Fixes: #35942

Contains a number of minor CSS fixes.

Fix missing border on targeted speech bubble
Screenshot 2025-11-06 at 22 43 31

Add padding to inline comments, slightly more padding around emoji button
Screenshot 2025-11-06 at 22 38 39

Center text on header in code search results
Screenshot 2025-11-06 at 22 08 01

Tweak emoji selector, reducing font size primarily
Screenshot 2025-11-06 at 22 29 46

Minor tweaks to repo sidebar, reduce font size by 1px, center "Release" text with label.
image

Fix issue comment buttons being misaligned on mobile
Screenshot 2025-11-06 at 22 50 19

Add highlight to actions re-run icon
Screenshot 2025-11-06 at 23 04 30

Fix actions re-run button overflow
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 6, 2025
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Nov 6, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 6, 2025
@silverwind
Copy link
Member Author

One more fix added to improve the issue timeline:

Before (content breaks out of box):
Screenshot 2025-11-07 at 13 24 18

After (content is wrapped and slightly more compact):
Screenshot 2025-11-07 at 13 23 57

@wxiaoguang

This comment was marked as resolved.

@wxiaoguang

This comment was marked as resolved.

@wxiaoguang wxiaoguang marked this pull request as draft November 7, 2025 12:52
@wxiaoguang

This comment was marked as resolved.

@silverwind
Copy link
Member Author

This damn history is so finicky, thanks for catching.

@wxiaoguang
Copy link
Contributor

This damn history is so finicky, thanks for catching.

Because there are so many hacky patches, unclear names, style conflicts.

@silverwind
Copy link
Member Author

silverwind commented Nov 7, 2025

Yes, it needs a redesign. I've reverted part of the changes, now it's only doing the wrapping (padding so it does not wrap exactly at element right side):

image

Line height is way too much here but I see no easy fix. The old code never assumed text to wrap.

@wxiaoguang
Copy link
Contributor

Line height is way too much here but I see no easy fix. The old code never assumed text to wrap.

Interesting, the regressions are all related to that problematic "line-height" 🤣

@silverwind silverwind marked this pull request as ready for review November 18, 2025 19:56
@silverwind
Copy link
Member Author

All comments are addressed.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 19, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) November 19, 2025 02:34
@wxiaoguang wxiaoguang merged commit 1da1e64 into go-gitea:main Nov 19, 2025
25 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Nov 19, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 19, 2025
Fixes: go-gitea#35913
Fixes: go-gitea#35942

Contains a number of minor CSS fixes.

---------

Signed-off-by: silverwind <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Nov 19, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 19, 2025
* giteaofficial/main:
  Misc CSS fixes (go-gitea#35888)
  Make composer registry support tar.gz and tar.bz2 and fix bugs (go-gitea#35958)
  Change project default column icon to 'star' (go-gitea#35967)
@silverwind silverwind deleted the misccss branch November 19, 2025 07:16
silverwind added a commit that referenced this pull request Nov 19, 2025
Backport #35888 by @silverwind

Fixes: #35913
Fixes: #35942

Contains a number of minor CSS fixes.

Fix missing border on targeted speech bubble
<img width="158" height="90" alt="Screenshot 2025-11-06 at 22 43 31"
src="https://github.com/user-attachments/assets/94696191-353a-4782-a998-2a3d5552ab71"
/>

Add padding to inline comments, slightly more padding around emoji
button
<img width="823" height="301" alt="Screenshot 2025-11-06 at 22 38 39"
src="https://github.com/user-attachments/assets/3ed8f113-13d2-4fad-9d12-81a670540e0b"
/>

Center text on header in code search results
<img width="1328" height="295" alt="Screenshot 2025-11-06 at 22 08 01"
src="https://github.com/user-attachments/assets/41e3d279-8504-4435-9347-e9b969cdfaa2"
/>

Tweak emoji selector, reducing font size primarily
<img width="251" height="219" alt="Screenshot 2025-11-06 at 22 29 46"
src="https://github.com/user-attachments/assets/e892646e-129f-44fd-8333-7a8e14863f03"
/>

Minor tweaks to repo sidebar, reduce font size by 1px, center "Release"
text with label.
<img width="390" height="586" alt="image"
src="https://github.com/user-attachments/assets/397dc36b-11e6-42df-bcdf-e97f4280a90e"
/>

Fix issue comment buttons being misaligned on mobile
<img width="757" height="160" alt="Screenshot 2025-11-06 at 22 50 19"
src="https://github.com/user-attachments/assets/1609d104-1bfe-4913-bfa0-6f4739716d61"
/>

Add highlight to actions re-run icon
<img width="116" height="106" alt="Screenshot 2025-11-06 at 23 04 30"
src="https://github.com/user-attachments/assets/0daed0ac-ef59-432a-b534-b4256d38393b"
/>

Fix actions re-run button overflow
<img width="214" height="125" alt="image"
src="https://github.com/user-attachments/assets/d5c79ce6-ad31-4c06-a411-d79eefb72d02"
/>

Signed-off-by: silverwind <[email protected]>
Co-authored-by: silverwind <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 24, 2025
* giteaofficial/release/v1.25: (77 commits)
  Add "site admin" back to profile menu (go-gitea#36010) (go-gitea#36013)
  release notes for 1.25.2 (go-gitea#35986)
  Allow empty commit when merging pull request with squash style (go-gitea#35989) (go-gitea#36003)
  Fix various permission & login related bugs (go-gitea#36002) (go-gitea#36004)
  upgrade golang.org/x/crypto to 0.45.0 (go-gitea#35988)
  Change project default column icon to 'star' (go-gitea#35967) (go-gitea#35979)
  Misc CSS fixes (go-gitea#35888) (go-gitea#35981)
  Fix container push tag overwriting (go-gitea#35936) (go-gitea#35954)
  Fix corrupted external render content (go-gitea#35946) (go-gitea#35950)
  Don't show unnecessary error message to end users for DeleteBranchAfterMerge (go-gitea#35937) (go-gitea#35941)
  Limit read bytes instead of ReadAll (go-gitea#35928) (go-gitea#35934)
  Load jQuery as early as possible to support custom scripts (go-gitea#35926) (go-gitea#35929)
  Allow to display embed images/pdfs when SERVE_DIRECT was enabled on MinIO storage (go-gitea#35882) (go-gitea#35917)
  Use correct form field for allowed force push users in branch protection API (go-gitea#35894) (go-gitea#35908)
  Make OAuth2 issuer configurable (go-gitea#35915) (go-gitea#35916)
  Fix go-gitea#35763: Add proper page title for project pages (go-gitea#35773) (go-gitea#35909)
  Display source code downloads last for release attachments (go-gitea#35897) (go-gitea#35903)
  Fix team member access check (go-gitea#35899) (go-gitea#35905)
  Fix conda null depend issue (go-gitea#35900) (go-gitea#35902)
  Fix avatar upload error handling (go-gitea#35887) (go-gitea#35890)
  ...

# Conflicts:
#	go.mod
#	go.sum
#	models/actions/run_test.go
#	models/fixtures/action_run.yml
#	models/fixtures/action_run_job.yml
#	models/fixtures/action_task.yml
#	models/fixtures/branch.yml
#	models/fixtures/repo_unit.yml
#	modules/git/tree_entry_gogit.go
#	modules/git/tree_gogit.go
#	routers/web/repo/actions/view.go
#	routers/web/repo/issue_comment.go
#	services/actions/workflow.go
#	services/doctor/actions_test.go
#	services/pull/comment.go
#	services/pull/pull.go
#	services/pull/temp_repo.go
#	templates/base/head_navbar.tmpl
#	templates/swagger/v1_json.tmpl
#	tests/integration/actions_schedule_test.go
#	tests/integration/git_lfs_ssh_test.go
#	tests/integration/pull_create_test.go
#	tests/integration/pull_merge_test.go
#	tests/sqlite.ini.tmpl
#	web_src/js/components/ContextPopup.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong ui around the comment button The text of the "Re-run all jobs" button is out of bounds on mobile devices.

4 participants